fix: SAR model to accept integer type for userId and itemId #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2274 Update SAR model to accept `userId` and `itemId` as integer types (`LongType`). * **SAR.scala** - Update `calculateUserItemAffinities` method to handle `userId` and `itemId` as `LongType`. - Update `calculateItemItemSimilarity` method to handle `userId` and `itemId` as `LongType`. * **test_ranking.py** - Add test case `test_adapter_evaluator_sar_with_long` to verify `userId` and `itemId` as `LongType`. * **Smart Adaptive Recommendations.md** - Update documentation to reflect that `userId` and `itemId` can be of `LongType`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/SynapseML/issues/2274?shareId=XXXX-XXXX-XXXX-XXXX).
Acrolinx ScorecardsA minimum total score of 80 is required. Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain customer trust in overall content quality.
More information about Acrolinx |
dciborow
changed the title
…tion/SAR.scala` file Delete `core/src/test/python/synapsemltest/recommendation/test_ranking.py` file Delete `docs/Explore Algorithms/Other Algorithms/Smart Adaptive Recommendations.md` file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2274
Update SAR model to accept
userIdanditemIdas integer types (LongType).SAR.scala
calculateUserItemAffinitiesmethod to handleuserIdanditemIdasLongType.calculateItemItemSimilaritymethod to handleuserIdanditemIdasLongType.test_ranking.py
test_adapter_evaluator_sar_with_longto verifyuserIdanditemIdasLongType.Smart Adaptive Recommendations.md
userIdanditemIdcan be ofLongType.For more details, open the Copilot Workspace session.