Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: This fixes a bug in our RestHelpers that would result into empty string returned from reading a http response content. Which subsequently cause exception while parsing the json #2046

Closed
wants to merge 2 commits into from
Closed

fix: This fixes a bug in our RestHelpers that would result into empty string returned from reading a http response content. Which subsequently cause exception while parsing the json #2046

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
310cbdd
This fixes a bug in our RestHelpers that would result into empty stri…
saileshbaidya Aug 9, 2023
fb7c6cc
Moving the empty inputstream check one step higher up in the stack
saileshbaidya Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions core/src/main/scala/com/microsoft/azure/synapse/ml/io/http/RESTHelpers.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,13 @@ object RESTHelpers {

def sendAndParseJson(request: HttpRequestBase, expectedCodes: Set[Int]=Set()): JsValue = {
val response = safeSend(request, expectedCodes=expectedCodes, close=false)
val output = parseResult(response).parseJson
response.close()
output
if(response.getEntity.getContent.available() == 0){
JsObject()
}
else {
val output = parseResult(response).parseJson
response.close()
output
}
}

}