avoid addtional param

microsoft · Aug 7, 2023 · 50d09ee · 50d09ee
1 parent c3cf48e
commit 50d09ee
Showing 1 changed file with 3 additions and 14 deletions.
diff --git a/cognitive/src/main/python/synapse/ml/cognitive/langchain/LangchainTransform.py b/cognitive/src/main/python/synapse/ml/cognitive/langchain/LangchainTransform.py
@@ -116,7 +116,6 @@ def __init__(
         subscriptionKey=None,
         url=None,
         apiVersion=OPENAI_API_VERSION,
-        useFabricInternalEndpoints=True,
     ):
         super(LangchainTransformer, self).__init__()
         self.chain = Param(
@@ -127,20 +126,17 @@ def __init__(
         self.subscriptionKey = Param(self, "subscriptionKey", "openai api key")
         self.url = Param(self, "url", "openai api base")
         self.apiVersion = Param(self, "apiVersion", "openai api version")
-        self.useFabricInternalEndpoints = Param(self, "useFabricInternalEndpoints", "use internal openai endpoints when on fabric")
         self.running_on_synapse_internal = running_on_synapse_internal()
-        if running_on_synapse_internal() and useFabricInternalEndpoints:
+        if running_on_synapse_internal():
             from synapse.ml.fabric.service_discovery import get_fabric_env_config
-            self.setUrl(get_fabric_env_config().fabric_env_config.ml_workload_endpoint + "cognitive/openai")
+            self._setDefault(url=get_fabric_env_config().fabric_env_config.ml_workload_endpoint + "cognitive/openai")
         kwargs = self._input_kwargs
         if subscriptionKey:
             kwargs["subscriptionKey"] = subscriptionKey
         if url:
             kwargs["url"] = url
         if apiVersion:
             kwargs["apiVersion"] = apiVersion
-        if useFabricInternalEndpoints:
-            kwargs["useFabricInternalEndpoints"] = useFabricInternalEndpoints
         self.setParams(**kwargs)
 
     @keyword_only
@@ -152,7 +148,6 @@ def setParams(
         subscriptionKey=None,
         url=None,
         apiVersion=OPENAI_API_VERSION,
-        useFabricInternalEndpoints=True,
     ):
         kwargs = self._input_kwargs
         return self._set(**kwargs)
@@ -163,12 +158,6 @@ def setChain(self, value):
     def getChain(self):
         return self.getOrDefault(self.chain)
 
-    def setUseFabricInternalEndpoints(self, value):
-        return self._set(useFabricInternalEndpoints=value)
-
-    def getUseFabricInternalEndpoints(self):
-        return self.getOrDefault(self.useFabricInternalEndpoints)
-
     def setSubscriptionKey(self, value: str):
         """
         set the openAI api key
@@ -212,7 +201,7 @@ def _transform(self, dataset):
         def udfFunction(x):
             import openai
 
-            if self.running_on_synapse_internal and self.getUseFabricInternalEndpoints():
+            if self.running_on_synapse_internal and not self.isSet(self.url):
                 from synapse.ml.fabric.prerun.openai_prerun import OpenAIPrerun
                 OpenAIPrerun(api_base=self.getUrl()).init_personalized_session(None)
             else: