Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<ranges>: Drop one superfluous _Fake_copy_init<bool> where the argument type is always bool #4465

Merged
merged 1 commit into from
Mar 16, 2024
Merged

<ranges>: Drop one superfluous _Fake_copy_init<bool> where the argument type is always bool #4465

merged 1 commit into from
Mar 16, 2024

Conversation

yronglin
Copy link
Contributor

Fixes #4394.

@yronglin yronglin requested a review from a team as a code owner March 10, 2024 13:25
@yronglin yronglin changed the title <ranges>: Drop one superfluous _Fake_copy_init<bool> where the argument type is always bool <ranges>: Drop one superfluous _Fake_copy_init<bool> where the argument type is always bool Mar 10, 2024
@StephanTLavavej StephanTLavavej added the throughput Must compile faster label Mar 10, 2024
@StephanTLavavej
Copy link
Member

Thanks, this looks great! We merge PRs simultaneously to the GitHub and MSVC-internal repos in a semi-manual process, batched up to save time. Your PR will be part of the next batch, likely later this week. I'll post comments here when that happens.

@yronglin
Copy link
Contributor Author

Thanks, this looks great! We merge PRs simultaneously to the GitHub and MSVC-internal repos in a semi-manual process, batched up to save time. Your PR will be part of the next batch, likely later this week. I'll post comments here when that happens.

Thanks for your review! It's an honor to contribute to STL.

@StephanTLavavej StephanTLavavej self-assigned this Mar 15, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 584144f into microsoft:main Mar 16, 2024
37 checks passed
@StephanTLavavej
Copy link
Member

Thanks for cleaning this up, and congratulations on your first microsoft/STL commit! 🎉 😻 🥳

This change is expected to ship in VS 2022 17.11 Preview 1.

@yronglin
Copy link
Contributor Author

Thanks for cleaning this up, and congratulations on your first microsoft/STL commit! 🎉 😻 🥳

This change is expected to ship in VS 2022 17.11 Preview 1.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels
throughput Must compile faster
Projects
STL Code Reviews
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<ranges>: Drop one superfluous _Fake_copy_init<bool> where the argument type is always bool
2 participants
@yronglin @StephanTLavavej