-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait on condition variables independently on system time #4457
Conversation
and don't need one
|
One of scary things here is locking down the |
The alternative could be a satellite DLL, this makes the change possible without core header extraction, but this can be more cumbersome overall. |
I think I'm fine with that limitation - the headers (not just the import lib) already know about the mutex representation, and the condition variable representation has been boiled down to its essentials now. Satellite DLLs are really annoying. I don't think we'll ever use them again unless we're absolutely forced to. There's one more transformation I want to perform (I want to get rid of the forward declaration squirrelliness) but that won't affect representation. |
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Thanks for fixing this notorious bug that we previously thought was unfixable! ⭐ 😻 🎉 |
Fix #718
Possibly create chaos (I hope not).
I made new core header, since making
<xthreads.h>
non-core looked hard.Thanks @achabense for the first step in this direction.