-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Rohde&Schwarz ZNLE VNA #6796
base: main
Are you sure you want to change the base?
Conversation
@FKMalina please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
from .ZNB import RohdeSchwarzZNBBase | ||
|
||
class ZNLE(RohdeSchwarzZNBBase): | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These short names are soft deprecated so let's not add them for new instruments.
Rather please create classes of the form RohdeSchwarzZNLE3 in a private file _rohde_schwarz_znle.py
and add the imports of these files to the __init__.py
file in the folder.
@FKMalina Thanks for the contribution. Looks good. Please fix the small issues pointed out by the precommit hooks and my inline comment and then this should be good to merge |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6796 +/- ##
==========================================
- Coverage 69.39% 69.38% -0.01%
==========================================
Files 340 341 +1
Lines 31335 31341 +6
==========================================
+ Hits 21744 21747 +3
- Misses 9591 9594 +3 ☔ View full report in Codecov by Sentry. |
This pull request includes minor changes to Rohde&Schwarz VNA driver, making it compatible with a family of the budget R&S VNA (ZNLE).