Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Awake: Corrected label: keep awake on interval -> for duration #34166

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

levid0s
Copy link

@levid0s levid0s commented Aug 5, 2024

Summary of the Pull Request

Corrected: Keep awake on interval -> Keep awake for duration

"Keep awake on interval" incorrectly suggests that a wake-up event is continuously sent at the selected interval (eg. every 30 minutes).

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@levid0s
Copy link
Author

levid0s commented Aug 5, 2024

@microsoft-github-policy-service agree

@dend
Copy link
Collaborator

dend commented Aug 5, 2024

We should not do the changes piecemeal - if we're changing terminology, it should be consistently changed across the app, everywhere where interval is used (including variable names and UI components).

Additionally, instead of for duration we should use for specified duration or for custom duration to avoid awkward phrasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants