Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KBM] PR Merge Branch #34038

Closed
wants to merge 19 commits into from

Conversation

gokcekantarci
Copy link
Contributor

Summary of the Pull Request

This PR includes

#31923
#32125
#32534

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@Jay-o-Way
Copy link
Collaborator

Why this PR?

@gokcekantarci
Copy link
Contributor Author

Why this PR?

There are some related tests of these 3 PRs. For example, Ctrl (not left or right) + a and Ctrl (not left or right) + b simultaneous shortcut invocation. A common PR to make testing easier.

@crutkas crutkas added the Needs-Review This Pull Request awaits the review of a maintainer. label Aug 6, 2024

This comment has been minimized.

@crutkas
Copy link
Member

crutkas commented Aug 20, 2024

fixed spelling error

@stefansjfw
Copy link
Collaborator

closing as we'll be merging original PRs one by one. One already merged

@stefansjfw stefansjfw closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Review This Pull Request awaits the review of a maintainer.
Projects
Development

Successfully merging this pull request may close these issues.

4 participants