Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DVLA Vehicle Enquiry Service (Independent Publisher) #3638

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

gulshankhurana
Copy link
Contributor

@gulshankhurana gulshankhurana commented Sep 3, 2024


When submitting a connector, please make sure that you follow the requirements below, otherwise your PR might be rejected. We want to make you have a well-built connector, a smooth certification experience, and your users are happy :)

If this is your first time submitting to GitHub and you need some help, please sign up for this session.

  • I attest that the connector doesn't exist on the Power Platform today. I've verified by checking the pull requests in GitHub and by searching for the connector on the platform or in the documentation.
  • I attest that the connector works and I verified by deploying and testing all the operations.
  • I attest that I have added detailed descriptions for all operations and parameters in the swagger file.
  • I attest that I have added response schemas to my actions, unless the response schema is dynamic.
  • I validated the swagger file, apiDefinition.swagger.json, by running paconn validate command.
  • If this is a certified connector, I confirm that apiProperties.json has a valid brand color and doesn't use an invalid brand color, #007ee5 or #ffffff. If this is an independent publisher connector, I confirm that I am not submitting a connector icon.

If you are an Independent Publisher, you must also attest to the following to ensure a smooth publishing process:

  • I have named this PR after the pattern of "Connector Name (Independent Publisher)" ex: HubSpot Marketing (Independent Publisher)
  • Within this PR markdown file, I have pasted screenshots that show: 3 unique operations (actions/triggers) working within a Flow. This can be in one flow or part of multiple flows. For each one of those flows, I have pasted in screenshots of the Flow succeeding.
  • Within this PR markdown file, I have pasted in a screenshot from the Test operations section within the Custom Connector UI.
  • If the connector uses OAuth, I have provided detailed steps on how to create an app in the readme.md.
DVLA connector test-1 DVLA Flow run-2

@gulshankhurana gulshankhurana requested a review from a team as a code owner September 3, 2024 20:02
Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @gulshankhurana,

Kindly remove the Proposal and add your artifacts. In addition to that title should be adhere to the Independent publisher checklist.

@gulshankhurana gulshankhurana marked this pull request as draft September 7, 2024 12:02
@gulshankhurana gulshankhurana changed the title Proposal - DVLA Vehicle Enquiry Service (UK) DVLA Vehicle Enquiry Service (Independent Publisher) Sep 7, 2024
@gulshankhurana gulshankhurana marked this pull request as ready for review September 7, 2024 12:05
@gulshankhurana
Copy link
Contributor Author

@vmanoharas, the title has been updated, as advised. The artifacts have also been added. Please note that the API performs only one action/operation hence only one screenshot of the test operation in the custom connector UI and one screenshot of the successful execution of the action in a flow.

@vmanoharas
Copy link
Contributor

@gulshankhurana
Copy link
Contributor Author

gulshankhurana commented Sep 10, 2024

Hello @gulshankhurana,

Kindly refer below links and submit all the necessary artifacts.

https://github.com/microsoft/PowerPlatformConnectors https://learn.microsoft.com/en-us/connectors/custom-connectors/certification-submission-ip

Hi @vmanoharas

I have already uploaded the apiDefinition swagger file and apiDefinition file along with readME file. What more is required? The link you've sent me gives instructions related to certifying a connector and talks about packaging a solution in zip file, uploading it on blob storage, getting SAS link and upload to the Partner Centre (as per the misleading link provided in 'Step 9 - Prepare the connector artifects). Being an independent publisher, I don't have access to Partner Centre and I don't have access to Azure Blob Storage either.

@vmanoharas
Copy link
Contributor

Hello @gulshankhurana,
Kindly refer below links and submit all the necessary artifacts.
https://github.com/microsoft/PowerPlatformConnectors https://learn.microsoft.com/en-us/connectors/custom-connectors/certification-submission-ip

Hi @vmanoharas

I have already uploaded the apiDefinition swagger file and apiDefinition file along with readME file. What more is required? The link you've sent me gives instructions related to certifying a connector and talks about packaging a solution in zip file, uploading it on blob storage, getting SAS link and upload to the Partner Centre (as per the misleading link provided in 'Step 9 - Prepare the connector artifects). Being an independent publisher, I don't have access to Partner Centre and I don't have access to Azure Blob Storage either.

Hi @gulshankhurana,

Sorry for the confusion, will review your connector.

updated publisher info
Copy link
Contributor

@vmanoharas vmanoharas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear Partner

I hope you are doing well.
Congratulations, your pull request is approved. We will move forward with the certification process. We are preparing your connector for production deployment and will queue up for the next deployment schedule. Once your connector onboards the next deployment schedule, it starts to deploy your connector in our production environments that typically takes 3-4 weeks.
Please let us know if you have any questions.
Thank you very much for working with us.

@vmanoharas
Copy link
Contributor

[[certify-connector]]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants