fix for msft python failing to detect pip packages due to pip needing… #8064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to be updated. in the StandardErrorLines it returns: "[notice] A new release of pip is available: 23.0.1 -> 24.3.1" "[notice] To update, run: C:\\Users\\bschnurr\\AppData\\Local\\Microsoft\\WindowsApps\\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\\python.exe -m pip install --upgrade pip" now we check for no packages found and error strings. if so we just set packages to null and it falls back to directory search to display instead.
|
bschnurr
commented
Nov 13, 2024
| foreach (var line in proc.StandardErrorLines) { | ||
| Debug.WriteLine(line); | ||
| } | ||
| packages = null; |
There was a problem hiding this comment.
below there is a case for null packages.
if (packages == null) {
// Pip failed, so return a directory listing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to be updated.
in the StandardErrorLines it returns:
"[notice] A new release of pip is available: 23.0.1 -> 24.3.1"
"[notice] To update, run: C:\Users\bschnurr\AppData\Local\Microsoft\WindowsApps\PythonSoftwareFoundation.Python.3.10_qbz5n2kfra8p0\python.exe -m pip install --upgrade pip"
now we check for no packages found and error strings. if so we just set packages to null and it falls back to directory search to display instead.
fixes #6774