Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set lib target framework to netstandard2.0 #55

Merged
merged 9 commits into from
Dec 6, 2023
Merged

Set lib target framework to netstandard2.0 #55

merged 9 commits into from
Dec 6, 2023

Conversation

peombwa
Copy link
Contributor

@peombwa peombwa commented Dec 5, 2023 •
edited
Loading

This PR fixes #53 by:

  • Changes lib target framework to netstandard2.0 to be compatible with OpenAPI.NET and Semantic Kernel.
  • Sets C# language version to 10 to be compatible with .NET 6, which is supported by Semantic Kernel.
  • Addresses changes attributed to the above changes.

@peombwa peombwa self-assigned this Dec 5, 2023
@peombwa peombwa marked this pull request as ready for review December 6, 2023 19:25
baywet
baywet requested changes Dec 6, 2023
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get why we're doing that, I'm just not happy to see the code go back in time 💩💩💩💩

src/lib/apimanifest.csproj Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

94.7% 94.7% Coverage
0.0% 0.0% Duplication

@peombwa peombwa enabled auto-merge December 6, 2023 22:25
@peombwa peombwa requested a review from baywet December 6, 2023 22:25
@peombwa peombwa merged commit ae734d6 into main Dec 6, 2023
7 checks passed
@peombwa peombwa deleted the po/TargetNetStandard2.0 branch December 6, 2023 22:29
@martincostello martincostello mentioned this pull request Nov 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet approved these changes

@zengin zengin zengin approved these changes

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

Assignees

@peombwa peombwa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support netstandard2.0 as a target framework
3 participants
@peombwa @zengin @baywet