-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ToApiManifest
extension method for converting an OpenAPI document to an APIManifest
#48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icrosoft/OpenApi.ApiManifest into po/AddsGenerationOfApiManifest
peombwa
requested review from
darrelmiller,
baywet and
zengin
as code owners
November 14, 2023 23:14
baywet
requested changes
Nov 15, 2023
zengin
suggested changes
Nov 15, 2023
zengin
previously approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for applying suggested changes!
baywet
requested changes
Nov 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for making the updates, a couple of things left.
Kudos, SonarCloud Quality Gate passed! |
zengin
approved these changes
Nov 16, 2023
baywet
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #46 by making the following changes:
OpenApi
toApiManifest
mapping doc that's implemented by the extension method.ToApiManifest
extension method forOpenApiDocument
. The method will be used dependent tools to convert and OpenAPI document to an ApiManifest.Proposed Usage