-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for conversion of API manifest document to OpenAI Plugin manifest #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peombwa
changed the title
Moves conversion of API manifest document to OpenAI Plugin manifest to an extension method
Adds support for conversion of API manifest document to OpenAI Plugin manifest
Oct 13, 2023
zengin
previously requested changes
Oct 13, 2023
@peombwa
|
baywet
requested changes
Oct 17, 2023
baywet
requested changes
Oct 18, 2023
baywet
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes
Kudos, SonarCloud Quality Gate passed! |
peombwa
dismissed
zengin’s stale review
October 18, 2023 18:57
Added code comment to helper method for clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #4 as a prerequisite for microsoft/OpenAPI.NET#1384 by:
ToOpenAIPluginManifestAsync
extension method to a valid instance ofApiManifestDocument
. The method uses imported logic from Hidi to generate an OpenAI Plugin manifest.Open Questions:
openApiFilePath
parameter (optional) toToOpenAIPluginManifestAsync
method?openApiFilePath
is required to instantiate OpenAI's Plugin manifestAPI
property that points to an API specification (file path or URL). Should we instead default toApiManifestDocument.ApiDescripionUrl
property instead?OpenApiManifest
, or should we just exposeToOpenAIPluginManifest
method that accepts an instanceOpenApiDocument
(customer fetches the OpenApiDocument outside the library)?References