dont abstract type for private fields #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonCropp
requested review from
irvinesunday,
darrelmiller,
peombwa,
zengin,
baywet,
millicentachieng,
MaggieKimani1 and
andrueastman
as code owners
baywet
approved these changes
Oct 6, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -17,11 +17,11 @@ | |||
| /// </summary> | |||
| public sealed class ValidationRuleSet : IEnumerable<ValidationRule> | |||
| { | |||
| private IDictionary<Type, IList<ValidationRule>> _rules = new Dictionary<Type, IList<ValidationRule>>(); | |||
| private Dictionary<Type, IList<ValidationRule>> _rules = new(); | |||
Check notice
Code scanning / CodeQL
Missed 'readonly' opportunity
|
|
||
| private static ValidationRuleSet _defaultRuleSet; | ||
|
|
||
| private IList<ValidationRule> _emptyRules = new List<ValidationRule>(); | ||
| private List<ValidationRule> _emptyRules = new(); |
Check notice
Code scanning / CodeQL
Missed 'readonly' opportunity
| @@ -30,7 +30,7 @@ | |||
| Diagnostic = diagnostic; | |||
| } | |||
|
|
|||
| private IDictionary<Type, Func<ParseNode, object>> _loaders = new Dictionary<Type, Func<ParseNode, object>> | |||
| private Dictionary<Type, Func<ParseNode, object>> _loaders = new() | |||
Check notice
Code scanning / CodeQL
Missed 'readonly' opportunity
| @@ -32,7 +32,7 @@ | |||
| Diagnostic = diagnostic; | |||
| } | |||
|
|
|||
| private IDictionary<Type, Func<ParseNode, object>> _loaders = new Dictionary<Type, Func<ParseNode, object>> | |||
| private Dictionary<Type, Func<ParseNode, object>> _loaders = new() | |||
Check notice
Code scanning / CodeQL
Missed 'readonly' opportunity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.