Fixes PR validation #1395
Merged
Fixes PR validation #1395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrueastman
requested review from
irvinesunday,
darrelmiller,
peombwa,
zengin,
baywet,
millicentachieng and
MaggieKimani1
as code owners
|
Kudos, SonarCloud Quality Gate passed! |
MaggieKimani1
approved these changes
Oct 5, 2023
baywet
reviewed
Oct 5, 2023
| # env: | ||
| # NUGET_API_KEY: ${{ secrets.NUGET_API_KEY }} | ||
|
|
||
| - name: Create and publish release |
There was a problem hiding this comment.
@andrueastman is there any specific reason why the create release task was removed?
There was a problem hiding this comment.
Disregard, I just saw the comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current CI does not fail on test failures but returns a false positive. See example at https://github.com/microsoft/OpenAPI.NET/actions/runs/6405608929/job/17388529486?pr=1393
This PR cleans up the workflow to
Failing test on dev branch have been fixed as well to unblock Hidi release via #1393