Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonSchema.NET Integration #1278

Merged
merged 225 commits into from
Nov 21, 2023

Update the schema registry reference URI and public API

1afe195
Select commit
Loading
Failed to load commit list.
Merged

JsonSchema.NET Integration #1278

Update the schema registry reference URI and public API
1afe195
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Nov 21, 2023 in 6s

3 new alerts

New alerts in code changed by this pull request

  • 2 warnings
  • 1 note

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 216 in src/Microsoft.OpenApi/Models/OpenApiRequestBody.cs

See this annotation in the file changed.

Code scanning / CodeQL

Futile conditional Warning

If-statement with an empty then-branch and no else-branch.

Check warning on line 132 in src/Microsoft.OpenApi/Validations/Rules/JsonSchemaRules.cs

See this annotation in the file changed.

Code scanning / CodeQL

Dereferenced variable may be null Warning

Variable
childSchema
Loading
may be null at this access as suggested by
this
Loading
null check.

Check notice on line 142 in src/Microsoft.OpenApi/Validations/Rules/JsonSchemaRules.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missed ternary opportunity Note

Both branches of this 'if' statement return - consider using '?' to express intent better.