Merge pull request #1408 from SimonCropp/remove-duplicate-dictionary-…

…lookups-in-ValidationRuleSet.Add remove duplicate dictionary lookups in ValidationRuleSet.Add
microsoft · Oct 6, 2023 · 543da26 · 543da26
2 parents a184a8f + 88bb6b9
commit 543da26
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/Microsoft.OpenApi/Validations/ValidationRuleSet.cs b/src/Microsoft.OpenApi/Validations/ValidationRuleSet.cs
@@ -123,17 +123,18 @@ public IList<ValidationRule> Rules
         /// <param name="rule">The rule.</param>
         public void Add(ValidationRule rule)
         {
-            if (!_rules.ContainsKey(rule.ElementType))
+            if (!_rules.TryGetValue(rule.ElementType, out var item))
             {
-                _rules[rule.ElementType] = new List<ValidationRule>();
+                _rules[rule.ElementType] = new List<ValidationRule> {rule};
+                return;
             }
 
-            if (_rules[rule.ElementType].Contains(rule))
+            if (item.Contains(rule))
             {
                 throw new OpenApiException(SRResource.Validation_RuleAddTwice);
             }
 
-            _rules[rule.ElementType].Add(rule);
+            item.Add(rule);
         }
 
         /// <summary>