[ci] fix some shellcheck warnings in package-building scripts #6641
Conversation
vnherdeiro
requested review from
guolinke,
jameslamb,
shiyu1994,
jmoralez,
borchero and
StrikerRUS
as code owners
No worries! We'll squash all of the history when this is merged anyway. |
|
That is a prompt review @jameslamb Thanks, will amend soonish! |
Co-authored-by: James Lamb <[email protected]>
Co-authored-by: James Lamb <[email protected]>
Co-authored-by: James Lamb <[email protected]>
…o shellcheck_fixes
build-python.sh
Outdated
| @@ -342,7 +346,7 @@ if test "${BUILD_SDIST}" = true; then | |||
| python -m build \ | |||
| --sdist \ | |||
| --outdir ../dist \ | |||
| ${BUILD_ARGS} \ | |||
| ${BUILD_ARGS:+ -o "$BUILD_ARGS"} \ | |||
There was a problem hiding this comment.
I don't understand this change, can you please explain it?
There was a problem hiding this comment.
@vnherdeiro are you still interested in this work and available to help? If not, could you please let us know so we can continue it in other PRs?
Co-authored-by: James Lamb <[email protected]>
Co-authored-by: James Lamb <[email protected]>
Co-authored-by: James Lamb <[email protected]>
Co-authored-by: James Lamb <[email protected]>
Co-authored-by: James Lamb <[email protected]>
|
@jameslamb thanks for the review and code suggestions about the more extent quotemarks! Do you mind if I start a new PR soon with changes for the files you had asked my to postpone from #6621 :
|
There was a problem hiding this comment.
Thanks for working on this.
I'm confused by several of these changes. As I've asked in previous reviews... please explain the reasoning for your proposes changes here. Several of these are not obvious at all, and it's difficult to review without knowing the underlying shellcheck warnings you're trying to address.
jameslamb
changed the title
|
@vnherdeiro will you have time in the next week to come back and work with us on this? If not, I'll close this and fix the remaining |
|
@jameslamb I am back and willing to continue working on this. |
|
Alright thanks. You can start here: #6641 (comment) |
Contributes to #6498 continues from #6621
Now I am tackling
./build-python.shand./build-cran-package.shAll feedback is welcome!
Please forgive the polluted commit history.