Simplify CMake test code #1164
Closed
Simplify CMake test code #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jpr42
commented
Oct 23, 2024
•
jpr42
commented
- Use FetchContent to grab googletest
- Simplify find_package testing so it's done as a part of ctest
- Use the GTest::gtest_main target directly
jpr42
commented
Oct 23, 2024
There was a problem hiding this comment.
This is now done when ctest is run. Which IMO is much more elegant.
jpr42
force-pushed
the
cmake-cleanup
branch
3 times, most recently
from
e11cd3d
to
ac38f88
Compare
- Use FetchContent to grab googletest - Simplify find_package testing so it's done as a part of ctest - Use the GTest::gtest_main target directly
jpr42
force-pushed
the
cmake-cleanup
branch
2 times, most recently
from
f964c96
to
99c807e
Compare
Currently testing will only run on pushes to main. This change allows testing on any branch which simplfies testing for forks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.