Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support using C++17 std::byte for FromMemory functions #504

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Conversation

walbourn
Copy link
Member

@walbourn walbourn commented Oct 31, 2024

When #497 was added to make the type of FromMemory operations use something other than void*, this turns out to result in code-breaks for clients using C++17's std::byte*.

This PR adds compat inlines to avoid requiring the client code add casts.

Minor tweak to CMake to avoid requiring all clients use the directxmath package externally.

@walbourn walbourn merged commit 77619f8 into main Oct 31, 2024
70 checks passed
@walbourn walbourn deleted the cpp17stdbyte branch October 31, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants