Fix Confidence Filter at Rule Level #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danfiedler-msft
previously approved these changes
Dec 9, 2024
danfiedler-msft
previously approved these changes
Dec 9, 2024
Update options tests to account for unspecified behavior (its the 0 value for the enum flag so always passes the check).
danfiedler-msft
approved these changes
Dec 9, 2024
danfiedler-msft
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying application inspector engine filters based on confidence level at the pattern level but not the rule level, but DevSkim does have a Rule level confidence value, which is supposed to be respected by the confidence filter option.
Fix #669.