Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rewriting files with no issues to suppress #632

Merged
merged 10 commits into from
Aug 27, 2024
Merged

Fix rewriting files with no issues to suppress #632

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d8058b9
Fix rewriting files with no issues to suppress
gfs Aug 23, 2024
e7308ca
Respect original newline characters when adding suppression comments
gfs Aug 26, 2024
91ab996
Add tests cases for fixes
gfs Aug 26, 2024
dbca276
Merge change from #628
gfs Aug 26, 2024
a3a3d67
Merge branch 'main' into gfs/#631
gfs Aug 26, 2024
3c9eeed
Merge branch 'gfs/#631' of https://github.com/microsoft/DevSkim into …
gfs Aug 26, 2024
f9c55d3
Update Changelog.md
gfs Aug 26, 2024
d6dd113
Update Changelog.md
gfs Aug 26, 2024
52cf205
Clean up
gfs Aug 26, 2024
bc46274
Also test multiline case
gfs Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions DevSkim-DotNet/Microsoft.DevSkim.CLI/Commands/SuppressionCommand.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,12 @@ public int Run()
issueRecords = issueRecords.Where(x => _opts.RulesToApplyFrom.Any(y => y == x.RuleId)).ToList();
}

// No issues remain for file after filtering to specified rule ids, skip file
if (!issueRecords.Any())
{
continue;
}

issueRecords
.Sort((a, b) => a.PhysicalLocation.Region.StartLine - b.PhysicalLocation.Region.StartLine);

Expand Down
Loading