Add tests to identify rules with missing or incomplete guidance #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converted to draft so its slightly clearer not to merge yet (though the failing PR tests also give a hint. |
|
Implementation of the tests looks spot on to me. Should sync on what to do about fixing the gaps/if they should be fatal yet as you mentioned. |
danfiedler-msft
force-pushed
the
guidance-test
branch
from
d805cfa to
4e5796e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two data-driven tests that verify rules:
It also adds guidance or points rules to the appropriate guidance file such that every default rule now has a guidance file.
The second test is temporarily marked as
[Ignore]to allow builds to pass. I plan to work on updating the incomplete (those with TODOs) in the near future which will allow us to remove[Ignore]from that test.