Also catch case where the recommendation is empty string (#532)

* Try fix missing Help.Text parameter when Recommendation and Description are both empty * More comprehensive fix
microsoft · May 25, 2023 · 95bfa6d · 95bfa6d
1 parent bd2e0f8
commit 95bfa6d
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/DevSkim-DotNet/Microsoft.DevSkim.CLI/Writers/SarifWriter.cs b/DevSkim-DotNet/Microsoft.DevSkim.CLI/Writers/SarifWriter.cs
@@ -202,7 +202,9 @@ private void AddRuleToSarifRule(DevSkimRule devskimRule)
                 sarifRule.FullDescription = new MultiformatMessageString() { Text = devskimRule.Description };
                 sarifRule.Help = new MultiformatMessageString()
                 {
-                    Text = devskimRule.Recommendation ?? devskimRule.Description ?? $"Visit {helpUri} for guidance on this issue.",
+                    // If recommendation is present use that, otherwise use description if present, otherwise use the HelpUri
+                    Text = !string.IsNullOrEmpty(devskimRule.Recommendation) ? devskimRule.Recommendation : 
+                        (!string.IsNullOrEmpty(devskimRule.Description) ? devskimRule.Description : $"Visit {helpUri} for guidance on this issue."),
                     Markdown = $"Visit [{helpUri}]({helpUri}) for guidance on this issue."
                 };
                 sarifRule.HelpUri = helpUri;