Add mergebot #1023
Add mergebot #1023
Conversation
| @@ -158,7 +158,7 @@ function doRestCall(call: RestMutation): Promise<void> { | |||
| const url = `https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/${call.op}`; | |||
| const headers = { | |||
| "accept": "application/vnd.github.v3+json", | |||
| "authorization": `token ${process.env.BOT_AUTH_TOKEN}`, | |||
There was a problem hiding this comment.
I would not recommend changing any of the token names; we have these set in the function app. If anything I would rather us become consistent and just do GITHUB_TOKEN like most other tools.
There was a problem hiding this comment.
oh, right. I got confused between the variables available to workflows vs functions.
.github/workflows/test.yml
Outdated
| @@ -0,0 +1,39 @@ | |||
| name: CI | |||
There was a problem hiding this comment.
Long term I don't think we need this; we already have a workflow which does testing and should be doing these tests.
| environment: | ||
| name: 'Production' | ||
| permissions: | ||
| id-token: write |
There was a problem hiding this comment.
| id-token: write | |
| contents: read | |
| id-token: write |
.github/workflows/deploy.yml
Outdated
| run: TYPESCRIPT_BOT_TOKEN=secret node packages/mergebot/dist/functions/index.js | ||
|
|
||
| - name: Create zip | ||
| run: zip -r ${{ env.FUNCTION_ZIP_NAME }} packagaes/mergebot/dist packages/mergebot/host.json packages/mergebot/package.json |
There was a problem hiding this comment.
Will need to check this; the paths put into the zip may now be nested because we're using longer paths as the input. Better would be to consistently use working-directory, then output to ${{ env.GITHUB_WORKSPACE }}/${{ env.FUNCTION_ZIP_NAME }}.
Restore to version from main, then install using the local version of pnpm.
1. Name conflict from changing TOO_MANY_FILES to tooManyFiles. Renamed again. 2. Placeholder tsconfig for mergebot test doesn't exist. There is no separate tconfig for tests!
Add entrypoints, ignore graphql, remove unused devDeps
1. Add test.yml steps to ci.yml. 2. Some fixes to deploy.yml. 2. jest now runs mergebot tests
No error on my machine, but maybe it'll help CI
Initial commit only so far. I made a list of tasks that I think need to happen and I'll ask for help vetting it.
Later: