remove array-type eslint rule (#1028)

Co-authored-by: Jake Bailey <[email protected]>
microsoft · Oct 14, 2024 · 9f35009 · 9f35009
1 parent af4e157
commit 9f35009
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 14 deletions.
diff --git a/.changeset/lemon-students-breathe.md b/.changeset/lemon-students-breathe.md
@@ -0,0 +1,5 @@
+---
+"@definitelytyped/eslint-plugin": patch
+---
+
+Remove array-type from config
diff --git a/packages/eslint-plugin/src/configs/all.ts b/packages/eslint-plugin/src/configs/all.ts
@@ -165,7 +165,6 @@ export const all: Linter.BaseConfig = {
         "@typescript-eslint/triple-slash-reference": ["error", { types: "prefer-import", path: "always" }],
         "@typescript-eslint/no-empty-interface": "error",
         "no-duplicate-imports": "error",
-        "@typescript-eslint/array-type": ["error", { default: "array-simple" }],
         "@typescript-eslint/naming-convention": [
           "error",
           {

diff --git a/packages/eslint-plugin/test/__file_snapshots__/types/expect/index.d.ts.lint b/packages/eslint-plugin/test/__file_snapshots__/types/expect/index.d.ts.lint
@@ -1,8 +1,4 @@
-types/expect/index.d.ts
-  7:12  error  Array type using 'readonly T[]' is forbidden for non-simple types. Use 'ReadonlyArray<T>' instead  @typescript-eslint/array-type
-
-✖ 1 problem (1 error, 0 warnings)
-  1 error and 0 warnings potentially fixable with the `--fix` option.
+No errors
 
 ==== types/expect/index.d.ts ====
 
@@ -13,7 +9,5 @@ types/expect/index.d.ts
     export function complicatedUnion<T extends string | number>(x: T, y: T): {
         prop1: "a" | "b" | "c";
         prop2: readonly (string | number)[];
-               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-!!! @typescript-eslint/array-type: Array type using 'readonly T[]' is forbidden for non-simple types. Use 'ReadonlyArray<T>' instead.
         prop3: ReadonlyArray<string | number>;
     };
diff --git a/packages/eslint-plugin/test/__snapshots__/plugin.test.ts.snap b/packages/eslint-plugin/test/__snapshots__/plugin.test.ts.snap
@@ -39,12 +39,6 @@ exports[`plugin should have the expected exports 1`] = `
             "@definitelytyped/redundant-undefined": "error",
             "@definitelytyped/strict-export-declare-modifiers": "error",
             "@typescript-eslint/adjacent-overload-signatures": "error",
-            "@typescript-eslint/array-type": [
-              "error",
-              {
-                "default": "array-simple",
-              },
-            ],
             "@typescript-eslint/ban-ts-comment": [
               "error",
               {