Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update linear.py compatible with torch 2.4.0 #5811

Merged

Conversation

terry-for-github
Copy link
Contributor

@terry-for-github terry-for-github commented Jul 30, 2024

deepspeed/runtime/zero/linear.py:67: FutureWarning: torch.cuda.amp.custom_bwd(args...) is deprecated. Please use torch.amp.custom_bwd(args..., device_type='cuda') instead.

Fixes: #5682

deepspeed/runtime/zero/linear.py:67: FutureWarning: `torch.cuda.amp.custom_bwd(args...)` is deprecated. Please use `torch.amp.custom_bwd(args..., device_type='cuda')` instead.
@loadams
Copy link
Contributor

loadams commented Jul 31, 2024

Thanks @terry-for-github! I'm running some tests on non-cuda hardware and we will merge this after tests complete.

xpu tests: https://github.com/microsoft/DeepSpeed/actions/runs/10186928945
hpu tests:https://github.com/microsoft/DeepSpeed/actions/runs/10186922974

@loadams loadams enabled auto-merge August 14, 2024 21:48
@loadams loadams added this pull request to the merge queue Aug 15, 2024
@loadams loadams removed this pull request from the merge queue due to a manual request Aug 15, 2024
@loadams loadams added this pull request to the merge queue Aug 16, 2024
@loadams loadams removed this pull request from the merge queue due to a manual request Aug 16, 2024
@loadams loadams enabled auto-merge August 16, 2024 17:31
@loadams loadams added this pull request to the merge queue Aug 20, 2024
Merged via the queue into microsoft:master with commit 96393f5 Aug 20, 2024
11 checks passed
@terry-for-github terry-for-github deleted the torch2.4.0-amp-futurewarning-patch branch August 31, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Logs full of FutureWarning when training with nightly PyTorch
3 participants