assumption of torch.initial_seed function accepting seed arg in DeepSpeedAccelerator abstract class is incorrect #5569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tjruwase @tohtana @mrwyattii @awan-10 please review this |
|
Thanks @polisettyvarma - it looks like this function never took the seed as an input so this is a good catch. |
loadams
approved these changes
May 28, 2024
|
Thank you @loadams for the review. |
polisettyvarma
changed the title
|
This is a great finding, thank you @polisettyvarma! |
tjruwase
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytorch API reference - https://pytorch.org/docs/stable/generated/torch.initial_seed.html
fix return value of manual_seed api for hpu