Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve KeyError: 'PDSH_SSH_ARGS_APPEND' #5318

Merged
merged 12 commits into from
Apr 1, 2024
Merged

resolve KeyError: 'PDSH_SSH_ARGS_APPEND' #5318

merged 12 commits into from
Apr 1, 2024

Conversation

Lzhang-hub
Copy link
Contributor

when start job with deepspeed --hostfile hostfile --master_addr $MASTER_IP --ssh_port 20023 src/train_bash.py

get error: KeyError: 'PDSH_SSH_ARGS_APPEND' in https://github.com/microsoft/DeepSpeed/blob/master/deepspeed/launcher/multinode_runner.py#L77

because PDSH_SSH_ARGS_APPEND not in environment.

@loadams
Copy link
Contributor

loadams commented Mar 27, 2024

Thanks @Lzhang-hub - have you tested that this change works for you?

@Lzhang-hub
Copy link
Contributor Author

Thanks @Lzhang-hub - have you tested that this change works for you?

yes, I had tested.

@loadams loadams added this pull request to the merge queue Apr 1, 2024
@loadams loadams removed this pull request from the merge queue due to a manual request Apr 1, 2024
@loadams loadams enabled auto-merge April 1, 2024 18:33
@loadams loadams added this pull request to the merge queue Apr 1, 2024
Merged via the queue into microsoft:master with commit cc897ec Apr 1, 2024
12 checks passed
rraminen pushed a commit to ROCm/DeepSpeed that referenced this pull request May 9, 2024
when start job with `deepspeed --hostfile hostfile --master_addr
$MASTER_IP --ssh_port 20023 src/train_bash.py `

get error: KeyError: 'PDSH_SSH_ARGS_APPEND' in
https://github.com/microsoft/DeepSpeed/blob/master/deepspeed/launcher/multinode_runner.py#L77

because PDSH_SSH_ARGS_APPEND not in environment.

---------

Co-authored-by: Logan Adams <[email protected]>
umchand pushed a commit to umchand/DeepSpeed that referenced this pull request May 20, 2024
when start job with `deepspeed --hostfile hostfile --master_addr
$MASTER_IP --ssh_port 20023 src/train_bash.py `

get error: KeyError: 'PDSH_SSH_ARGS_APPEND' in
https://github.com/microsoft/DeepSpeed/blob/master/deepspeed/launcher/multinode_runner.py#L77

because PDSH_SSH_ARGS_APPEND not in environment.

---------

Co-authored-by: Logan Adams <[email protected]>
dbyoung18 pushed a commit to dbyoung18/DeepSpeed that referenced this pull request Jun 11, 2024
when start job with `deepspeed --hostfile hostfile --master_addr
$MASTER_IP --ssh_port 20023 src/train_bash.py `

get error: KeyError: 'PDSH_SSH_ARGS_APPEND' in
https://github.com/microsoft/DeepSpeed/blob/master/deepspeed/launcher/multinode_runner.py#L77

because PDSH_SSH_ARGS_APPEND not in environment.

---------

Co-authored-by: Logan Adams <[email protected]>
aslanxie added a commit to aslanxie/DeepSpeed that referenced this pull request Sep 4, 2024
resolve KeyError: 'PDSH_SSH_ARGS_APPEND' (microsoft#5318)
when start job with `deepspeed --hostfile hostfile --master_addr
$MASTER_IP --ssh_port 20023 src/train_bash.py `

get error: KeyError: 'PDSH_SSH_ARGS_APPEND' in
https://github.com/microsoft/DeepSpeed/blob/master/deepspeed/launcher/multinode_runner.py#L77

because PDSH_SSH_ARGS_APPEND not in environment.

---------

Co-authored-by: Logan Adams <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants