Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip 1Bit Compression and sparsegrad tests for HPU. #5270

Merged

Conversation

vshekhawat-hlab
Copy link
Contributor

HPU accelrator does not support 1bit and sparsegrad tests.

HPU accelrator does not support 1bit and sparsegrad tests.
@loadams loadams added this pull request to the merge queue Mar 13, 2024
Merged via the queue into microsoft:master with commit d2ef20e Mar 13, 2024
12 checks passed
@delock
Copy link
Collaborator

delock commented Mar 14, 2024

Ideally a test should check for accelerator feature instead of check for accelerator name. So other accelerators could skip the test without modifying the test code again. This also gives DeepSpeed code a chance to gracefully skip some feature instead of run into error. Might be some API i.e. if "1bit" in get_accelerator().capabilities() etc.

This could apply to feature that does not require an opbuilder. For feature using opbuilder, a typical feature check could be check compatibility of the opbuilder.

@tjruwase @loadams @vshekhawat-hlab

@loadams
Copy link
Contributor

loadams commented Mar 14, 2024

@delock - agreed, I'll look into this as well as your torch.compile comment on the other PR.

@tjruwase
Copy link
Contributor

Ideally a test should check for accelerator feature instead of check for accelerator name. So other accelerators could skip the test without modifying the test code again. This also gives DeepSpeed code a chance to gracefully skip some feature instead of run into error. Might be some API i.e. if "1bit" in get_accelerator().capabilities() etc.

This could apply to feature that does not require an opbuilder. For feature using opbuilder, a typical feature check could be check compatibility of the opbuilder.

@tjruwase @loadams @vshekhawat-hlab

@delock, FYI we are trying to do this in #5423. It would be great to get your thoughts. Thanks!

@duli2012, FYI

rraminen pushed a commit to ROCm/DeepSpeed that referenced this pull request May 9, 2024
HPU accelrator does not support 1bit and sparsegrad tests.
dbyoung18 pushed a commit to dbyoung18/DeepSpeed that referenced this pull request Jun 11, 2024
HPU accelrator does not support 1bit and sparsegrad tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants