Average only valid part of the ipg buffer. #5268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When contiguous gradients is used ipg buffer may not be fully utilized. Call average_tensor only for the slice with valid gradints Change-Id: I760559d52c2f91e15cd6cd0b48e534ec2352802a
tjruwase
approved these changes
Mar 13, 2024
|
@BacharL, thanks for catching this corner case. |
rraminen
pushed a commit
to ROCm/DeepSpeed
that referenced
this pull request
May 9, 2024
When contiguous gradients is used ipg buffer may not be fully utilized. Call average_tensor only for the slice with valid gradints Change-Id: I760559d52c2f91e15cd6cd0b48e534ec2352802a Co-authored-by: Logan Adams <[email protected]>
dbyoung18
pushed a commit
to dbyoung18/DeepSpeed
that referenced
this pull request
Jun 11, 2024
When contiguous gradients is used ipg buffer may not be fully utilized. Call average_tensor only for the slice with valid gradints Change-Id: I760559d52c2f91e15cd6cd0b48e534ec2352802a Co-authored-by: Logan Adams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When contiguous gradients is used ipg buffer may not be fully utilized. Call average_tensor only for the slice with valid gradints
Change-Id: I760559d52c2f91e15cd6cd0b48e534ec2352802a