Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hooks on gradient accumulation on engine/optimizer destroy #4858

Merged
merged 7 commits into from
Dec 30, 2023
Merged

Remove hooks on gradient accumulation on engine/optimizer destroy #4858

merged 7 commits into from
Dec 30, 2023

Conversation

chiragjn
Copy link
Contributor

@chiragjn chiragjn commented Dec 21, 2023 •
edited
Loading

@chiragjn
Copy link
Contributor Author

@microsoft-github-policy-service agree

@chiragjn chiragjn mentioned this pull request Dec 21, 2023
Closed
4 tasks
@chiragjn chiragjn requested a review from awan-10 as a code owner December 21, 2023 09:50
@chiragjn chiragjn mentioned this pull request Dec 21, 2023
Closed
@chiragjn
Copy link
Contributor Author

@mrwyattii requesting for a review

@tjruwase tjruwase added this pull request to the merge queue Dec 30, 2023
Merged via the queue into microsoft:master with commit 4034205 Dec 30, 2023
14 checks passed
mauryaavinash95 pushed a commit to mauryaavinash95/DeepSpeed that referenced this pull request Feb 17, 2024
@chiragjn
Remove hooks on gradient accumulation on engine/optimizer destroy (mi…
ce79d2a 
…crosoft#4858)

Fixes: microsoft#4856 
See: pytorch/pytorch#46386
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjruwase tjruwase tjruwase approved these changes

@mrwyattii mrwyattii Awaiting requested review from mrwyattii

@awan-10 awan-10 Awaiting requested review from awan-10

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Deepspeed ZeRO Optimizer Stage 2 Memory Leak? How to cleanup?
2 participants
@chiragjn @tjruwase