Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zero_to_fp32.py: Handle a case where shape doesn't have numel attr #4842

Merged
merged 3 commits into from
Jan 3, 2024
Merged

zero_to_fp32.py: Handle a case where shape doesn't have numel attr #4842

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ecc3ee6
zero_to_fp32.py: Handle a case where shape doesn't have numel attr
nelyahu Dec 20, 2023
05d0f1d
Merge branch 'master' into zero_to_fp32_has_callable
tjruwase Dec 20, 2023
cffa234
Merge branch 'master' into zero_to_fp32_has_callable
loadams Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion deepspeed/utils/zero_to_fp32.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,11 @@ def _zero2_merge_frozen_params(state_dict, zero_model_states):
print(f"Reconstructed Frozen fp32 state dict with {total_params} params {total_numel} elements")


def _has_callable(obj, fn):
attr = getattr(obj, fn, None)
return callable(attr)


def _zero2_merge_trainable_params(state_dict, world_size, fp32_flat_groups, zero_model_states):
param_shapes = zero_model_states[0].param_shapes

Expand Down Expand Up @@ -287,7 +292,7 @@ def _zero2_merge_trainable_params(state_dict, world_size, fp32_flat_groups, zero
avail_numel = full_single_fp32_vector.numel()
for name, shape in shapes.items():

unpartitioned_numel = shape.numel()
unpartitioned_numel = shape.numel() if _has_callable(shape, 'numel') else math.prod(shape)
total_numel += unpartitioned_numel
total_params += 1

Expand Down