Checkpointing: Avoid assigning tensor storage with different device #4836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some back-ends, assigning tensor.data to a storage being on a different device than the tensor, is not supported. The fix is saving the storage in a temp member and restoring tensor.data when needed.
tjruwase
approved these changes
Dec 18, 2023
deepcharm
deleted the
chkp-avoid-assign-tensor-storage-on-different-device
branch
mauryaavinash95
pushed a commit
to mauryaavinash95/DeepSpeed
that referenced
this pull request
Feb 17, 2024
…icrosoft#4836) On some back-ends, assigning tensor.data to a storage being on a different device than the tensor is not supported. The fix is to save the storage in a temp data member and restore tensor.data when needed. Co-authored-by: Olatunji Ruwase <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some back-ends, assigning tensor.data to a storage being on a different
device than the tensor is not supported.
The fix is to save the storage in a temp data member and restore tensor.data
when needed.