Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update imports from Transformers #4817

Merged
merged 4 commits into from
Dec 15, 2023
Merged

Update imports from Transformers #4817

merged 4 commits into from
Dec 15, 2023

Conversation

loadams
Copy link
Contributor

@loadams loadams commented Dec 14, 2023 •
edited
Loading

This helps resolve the following warnings:

  /tmp/actions-runner/_work/DeepSpeed/DeepSpeed/unit-test-venv/lib/python3.8/site-packages/transformers/deepspeed.py:23: FutureWarning: transformers.deepspeed module is deprecated and will be removed in a future version. Please import deepspeed modules directly from transformers.integrations
    warnings.warn(

@loadams loadams changed the title Transformers future deprecations Update imports from Transformers Dec 14, 2023
@mrwyattii
Copy link
Contributor

@loadams I think we should also set a minimum transformers version in requirement files that have transformers listed (e.g., https://github.com/microsoft/DeepSpeed/blob/master/requirements/requirements-dev.txt). It looks like v4.32.1 is when the import was moved to transformers.integrations.

@loadams
Copy link
Contributor Author

loadams commented Dec 15, 2023

@loadams I think we should also set a minimum transformers version in requirement files that have transformers listed (e.g., https://github.com/microsoft/DeepSpeed/blob/master/requirements/requirements-dev.txt). It looks like v4.32.1 is when the import was moved to transformers.integrations.

Makes sense, I hadn't looked up the version number, but that sounds good, should be updated now.

@mrwyattii mrwyattii merged commit b83b1c2 into master Dec 15, 2023
14 of 15 checks passed
@mrwyattii mrwyattii deleted the loadams/update-transformers-deepspeed-modules branch December 15, 2023 22:12
mauryaavinash95 pushed a commit to mauryaavinash95/DeepSpeed that referenced this pull request Feb 17, 2024
@loadams
Update imports from Transformers (microsoft#4817)
ee383bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrwyattii mrwyattii mrwyattii approved these changes

@tjruwase tjruwase Awaiting requested review from tjruwase tjruwase is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loadams @mrwyattii