Unit tests for MiCS #4792
Merged
Unit tests for MiCS #4792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zarzen, thanks! |
mrwyattii
suggested changes
Dec 15, 2023
|
@mrwyattii thanks for suggestions, I updated the implementation accordingly. Besides, as the mics implementation currently is not compatible with offloading, I removed the unittest for |
loadams
approved these changes
Jan 8, 2024
mrwyattii
approved these changes
Jan 8, 2024
mauryaavinash95
pushed a commit
to mauryaavinash95/DeepSpeed
that referenced
this pull request
Feb 17, 2024
In response to the ask from microsoft#2964 (comment), I added three more unit tests related to MiCS. There are two knowledge issues: - Testing on Torch 2.1.0 triggers `_IllegalWorker` in coalesced all gather. I made changes to ignore this condition. and Currently, I don't know the reason. - The MiCS implementation is not working with offloading, so the failure in `TestZeroPartialOffloadConfigSweep` is expected. --------- Co-authored-by: Logan Adams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to the ask from #2964 (comment), I added three more unit tests related to MiCS.
There are two knowledge issues:
_IllegalWorkerin coalesced all gather. I made changes to ignore this condition. and Currently, I don't know the reason.TestZeroPartialOffloadConfigSweepis expected.