Inference changes for incorporating meta loading checkpoint #4692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
oelayan7
commented
Nov 16, 2023
oelayan7
commented
- In both files, the same logic was done that if when it is meta no need to move the tensors to the device.
- Deletion of an unused member of the class
oelayan7
requested review from
RezaYazdaniAminabadi,
jeffra,
mrwyattii,
awan-10,
cmikeh2 and
arashb
as code owners
|
@RezaYazdaniAminabadi @jeffra Can you please review |
|
@mrwyattii / @awan-10 can you please check this PR and if it looks good merge it please, thanks :) |
tjruwase
approved these changes
Dec 18, 2023
mrwyattii
approved these changes
Dec 18, 2023
mauryaavinash95
pushed a commit
to mauryaavinash95/DeepSpeed
that referenced
this pull request
Feb 17, 2024
…t#4692) 1. In both files, the same logic was done that if when it is meta no need to move the tensors to the device. 2. Deletion of an unused member of the class --------- Co-authored-by: Olatunji Ruwase <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.