Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MII] catch error wrt HF version and Mistral #4634

Merged
merged 4 commits into from
Nov 13, 2023
+5 −0
Merged

[MII] catch error wrt HF version and Mistral #4634

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
22c5bb1
Catch error wrt HF version and Mistral
jeffra Nov 6, 2023
dae1a46
address comment
jeffra Nov 6, 2023
37b5921
Merge branch 'master' into mistral-check
loadams Nov 9, 2023
191e370
Merge branch 'master' into mistral-check
jeffra Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions deepspeed/inference/v2/engine_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

import logging
from typing import Any
from packaging import version

from .engine_v2 import InferenceEngineV2
from .config_v2 import RaggedInferenceEngineConfig
Expand Down Expand Up @@ -39,6 +40,10 @@ def build_hf_engine(path: str,
policy = Llama2Policy(checkpoint_engine, model_config)
elif model_config.model_type == "mistral":
from .model_implementations.mistral.policy import MistralPolicy
# Ensure we're using the correct version of transformers for mistral
import transformers
assert version.parse(transformers.__version__) >= version.parse("4.34.0"), \
f"Mistral requires transformers >= 4.34.0, you have version {transformers.__version__}"
policy = MistralPolicy(checkpoint_engine, model_config)
else:
raise ValueError(f"Unsupported model type {model_config.model_type}")
Expand Down