Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added __HIP_PLATFORM_AMD__=1 for non JIT build #4585

Merged
merged 7 commits into from
Nov 8, 2023
Merged

Added __HIP_PLATFORM_AMD__=1 for non JIT build #4585

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5234a76
Added __HIP_PLATFORM_AMD__=1 for non JIT build
rraminen Oct 30, 2023
f2915d5
Merge branch 'master' into hip_platform_amd_non_jit_build
loadams Nov 3, 2023
addcaad
Merge branch 'master' into hip_platform_amd_non_jit_build
loadams Nov 6, 2023
7875ea5
Merge branch 'master' into hip_platform_amd_non_jit_build
loadams Nov 6, 2023
6651498
Merge branch 'master' into hip_platform_amd_non_jit_build
loadams Nov 7, 2023
438d98d
Merge branch 'master' into hip_platform_amd_non_jit_build
loadams Nov 7, 2023
8986145
Merge branch 'master' into hip_platform_amd_non_jit_build
loadams Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions op_builder/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,6 +616,9 @@ def builder(self):
if not self.build_for_cpu and self.enable_bf16:
compile_args['cxx'].append("-DBF16_AVAILABLE")

if self.is_rocm_pytorch():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rraminen - do we need both this change and the one in #4570?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that #4585 is for non-JIT builds and #4570 is for JIT builds. So both of them are required. Please correct me if wrong.

compile_args['cxx'].append("-D__HIP_PLATFORM_AMD__=1")

cuda_ext = ExtensionBuilder(name=self.absolute_name(),
sources=self.strip_empty_entries(self.sources()),
include_dirs=self.strip_empty_entries(self.include_paths()),
Expand Down