-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix assert on Lamb optimizers with BF16 #4451
Open
loadams
wants to merge
17
commits into
master
Choose a base branch
from
loadams/lamb-bf16
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
548852c
Add bf16 check
loadams 2f10df5
Format fixes
loadams 023aa62
Merge branch 'master' into loadams/lamb-bf16
loadams 35aabdc
Merge branch 'master' into loadams/lamb-bf16
loadams 9eb6af6
Fix issue before
loadams 1ef677b
fp16_enabled() not float16_enabled()
loadams 1d87c24
Merge branch 'master' into loadams/lamb-bf16
tjruwase 45577e5
Merge branch 'master' into loadams/lamb-bf16
loadams 7c71aa8
Merge branch 'master' into loadams/lamb-bf16
loadams 0b330c1
Merge branch 'master' into loadams/lamb-bf16
loadams 117b4df
Merge branch 'master' into loadams/lamb-bf16
loadams bb99d04
Merge branch 'master' into loadams/lamb-bf16
loadams e468fee
Merge branch 'master' into loadams/lamb-bf16
loadams ccda5fe
Merge branch 'master' into loadams/lamb-bf16
loadams ecfba27
Merge branch 'master' into loadams/lamb-bf16
loadams 8033e99
Merge branch 'master' into loadams/lamb-bf16
loadams 9addfd1
Merge branch 'master' into loadams/lamb-bf16
loadams File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will try switching to check the optimizer wrapper as BFLOAT16 rather than just checking if bfloat is enabled