Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in bfloat16 optimizer related to checkpointing #4434

Merged
merged 10 commits into from
Oct 7, 2023
Merged

Fix bug in bfloat16 optimizer related to checkpointing #4434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0254fbf
fix: bf16 optimizer if condition
okoge-kaz Oct 1, 2023
c03a6cf
fix: unexpected keyword argument 'load_serial'
okoge-kaz Oct 1, 2023
4422e13
fix: add load_serial arg to bf16_optimizer
okoge-kaz Oct 3, 2023
ab6a8c7
style: fix indentation
okoge-kaz Oct 3, 2023
4c98f41
Merge branch 'master' into fix/bf16-optimizer-state
tjruwase Oct 4, 2023
bbca61e
Merge branch 'master' into fix/bf16-optimizer-state
okoge-kaz Oct 5, 2023
03dfdcd
Merge branch 'master' into fix/bf16-optimizer-state
okoge-kaz Oct 5, 2023
a8a538b
Merge branch 'master' into fix/bf16-optimizer-state
okoge-kaz Oct 6, 2023
e83e7c4
Merge branch 'master' into fix/bf16-optimizer-state
okoge-kaz Oct 6, 2023
812f532
Merge branch 'master' into fix/bf16-optimizer-state
okoge-kaz Oct 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion deepspeed/runtime/bf16_optimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,8 @@ def load_state_dict(self,
state_dict_list,
checkpoint_folder,
load_optimizer_states=True,
load_from_fp32_weights=False):
load_from_fp32_weights=False,
load_serial=None):
if checkpoint_folder:
self._load_universal_checkpoint(checkpoint_folder, load_optimizer_states, load_from_fp32_weights)
else:
Expand Down
2 changes: 1 addition & 1 deletion deepspeed/runtime/engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3287,7 +3287,7 @@ def _get_zero_param_shapes(self):
# if we don't use it, we get parameters ordered incorrectly
if hasattr(self.optimizer, "round_robin_bit16_groups"):
bit16_groups = self.optimizer.round_robin_bit16_groups
elif self.bfloat16_enabled() and not self.zero_optimization():
elif self.bfloat16_enabled() and hasattr(self.optimizer, "bf16_groups"):
bit16_groups = self.optimizer.bf16_groups
else:
bit16_groups = self.optimizer.bit16_groups if self.zero_optimization_stage(
Expand Down