Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flops profiler to recurse #4374

Merged
merged 6 commits into from
Nov 21, 2023
Merged

Conversation

loadams
Copy link
Contributor

@loadams loadams commented Sep 20, 2023

Fixes #4334.

Copy link
Contributor

@lekurile lekurile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Perform FLOPs profiler testing.

@loadams
Copy link
Contributor Author

loadams commented Nov 21, 2023

TODO: Perform FLOPs profiler testing.

Done, see comments on the linked issue.

@loadams loadams added this pull request to the merge queue Nov 21, 2023
Merged via the queue into master with commit 6139122 Nov 21, 2023
15 checks passed
mauryaavinash95 pushed a commit to mauryaavinash95/DeepSpeed that referenced this pull request Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] FlopsProfiler does not recurse when calculating module duration
3 participants