Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user arg parsing in single node deployment #4007

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Fix user arg parsing in single node deployment #4007

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfc72ec
fix for single node launching with user args
mrwyattii Jul 20, 2023
4a774c1
fix with shlex
mrwyattii Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions deepspeed/launcher/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import os
import re
import sys
import shlex
import json
import base64
import argparse
Expand Down Expand Up @@ -382,6 +383,9 @@ def parse_num_nodes(str_num_nodes: str, elastic_training: bool):
def main(args=None):
args = parse_args(args)

# For when argparse interprets remaining args as a single string
args.user_args = shlex.split(" ".join(args.user_args))

if args.elastic_training:
assert args.master_addr != "", "Master Addr is required when elastic training is enabled"

Expand Down