Skip to content

Commit

Permalink
resolve PDSH_SSH_ARGS_APPEND not in environment
Browse files Browse the repository at this point in the history
  • Loading branch information
Lzhang-hub committed Mar 26, 2024
1 parent 0529eac commit a6ccbca
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions deepspeed/launcher/multinode_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@ def name(self):

def get_cmd(self, environment, active_resources):
environment['PDSH_RCMD_TYPE'] = 'ssh'
if self.args.ssh_port is not None: # only specify ssh port if it is specified
environment["PDSH_SSH_ARGS_APPEND"] += f" -p {self.args.ssh_port}"
if self.args.ssh_port is not None: # only specify ssh port if it is specified
environment["PDSH_SSH_ARGS_APPEND"] = f"{environment.get('PDSH_SSH_ARGS_APPEND', '')} -p {self.args.ssh_port}"

active_workers = ",".join(active_resources.keys())
logger.info("Running on the following workers: %s" % active_workers)
Expand Down

0 comments on commit a6ccbca

Please sign in to comment.