Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shorten MC run in CI verification to fit in CI timescale #6531

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Shorten MC run in CI verification to fit in CI timescale #6531

merged 3 commits into from
Oct 7, 2024

Conversation

achamayou
Copy link
Member

No description provided.

@achamayou achamayou requested a review from a team October 7, 2024 13:20
@achamayou achamayou mentioned this pull request Oct 7, 2024
Closed
heidihoward
heidihoward approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@heidihoward heidihoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve this as its clearly needed but I would like to find a way to bring back exhaustive checking with 3 (or more) nodes and view changes

@achamayou
Copy link
Member Author

@heidihoward agreed, I tried a few options (disable quorum, disable refinement) with 1 view change and 1 request, but nothing runs in the kind of timescale that fits CI runs.

@achamayou achamayou added this pull request to the merge queue Oct 7, 2024
Merged via the queue into microsoft:main with commit 261602d Oct 7, 2024
19 checks passed
@achamayou achamayou deleted the shorten_ci_mc branch October 7, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heidihoward heidihoward heidihoward approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achamayou @heidihoward