[WIP] [DRAFT] COSE back-endorsements #6510
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxtropets
changed the title
maxtropets
commented
Sep 30, 2024
maxtropets
commented
Sep 30, 2024
maxtropets
commented
Sep 30, 2024
maxtropets
commented
Sep 30, 2024
…m:maxtropets/CCF into f/6500-cose-service-identity-endorsements
maxtropets
commented
Oct 1, 2024
| ccf::Tables::PREVIOUS_SERVICE_IDENTITY_ENDORSEMENT); | ||
| try | ||
| { | ||
| const auto pubkey = ccf::crypto::public_key_pem_from_cert( |
There was a problem hiding this comment.
To discuss if this must be moved to the final recovery TX, or can stay in here.
Pros for leaving it as is
- simplifies chain lookup
Cons
- not really safe to endorse smth with the service key until members have signed off service opening
However
- If recovery isn't completed - the incomplete endorsement will be lost
- During recovery we won't produce endorsements anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6500