Configure hist. cache size on startup #6346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxtropets
force-pushed
the
f/6299-historical-cache-config
branch
3 times, most recently
from
c6de476
to
6a3d52a
Compare
maxtropets
commented
Jul 9, 2024
maxtropets
force-pushed
the
f/6299-historical-cache-config
branch
from
6a3d52a
to
2f79028
Compare
eddyashton
reviewed
Jul 9, 2024
achamayou
reviewed
Jul 9, 2024
achamayou
approved these changes
Jul 9, 2024
|
@maxtropets can you run the historical query benchmark and post the number on the PR? |
maxtropets
changed the title
maxtropets
force-pushed
the
f/6299-historical-cache-config
branch
2 times, most recently
from
d3e7df6
to
f5169c3
Compare
maxtropets
changed the title
achamayou
reviewed
Jul 10, 2024
achamayou
approved these changes
Jul 10, 2024
maxtropets
changed the title
maxtropets
force-pushed
the
f/6299-historical-cache-config
branch
2 times, most recently
from
6d6cb71
to
c422bb9
Compare
maxtropets
force-pushed
the
f/6299-historical-cache-config
branch
from
c422bb9
to
548f8bb
Compare
maxtropets
force-pushed
the
f/6299-historical-cache-config
branch
from
2b5db0c
to
6f0ff83
Compare
|
New version does remove Let's discuss if that's worth it |
maxtropets
changed the title
eddyashton
approved these changes
Jul 12, 2024
achamayou
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6299