Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service endorsements as COSE during DR #6500

Open
1 of 3 tasks
maxtropets opened this issue Sep 25, 2024 · 2 comments · May be fixed by #6510
Open
1 of 3 tasks

Service endorsements as COSE during DR #6500

maxtropets opened this issue Sep 25, 2024 · 2 comments · May be fixed by #6510
Assignees

Comments

@maxtropets
Copy link
Contributor

maxtropets commented Sep 25, 2024

Return COSE service identity endorsements chain in historical TX receipts.

Tasks

@maxtropets maxtropets self-assigned this Sep 27, 2024
@maxtropets maxtropets linked a pull request Sep 27, 2024 that will close this issue
@maxtropets
Copy link
Contributor Author

@achamayou @eddyashton, regarding the services with lots of DRs, shall we introduce a new request parameter to ask for the endorsements chain explicitly?

Possible options

  • I want the full chain
  • I want a shortened chain (not really sure how, create a chain digest or smth?, or counter-sign only the original service identity at the time of TX in question, as we do for current endorsements)
  • I don't want a chain

@achamayou
Copy link
Member

achamayou commented Sep 27, 2024

@maxtropets we can do, but the chain should only get substantial if you ask for receipts that are many DRs ago. If you ask for recent receipts, it'll still be short. Having an option to skip endorsements definitely makes sense, and an endpoint to just get the chain (or even the chain in a tx range).

Proposal:

GET /node/receipt | x-ms-ccf-txid: 5.578 => receipt + full chain
GET /node/receipt?asof=now | x-ms-ccf-txid: 5.578 => receipt + full chain
GET /node/receipt?asof=7.999 | x-ms-ccf-txid: 5.578 => receipt + chain from 5.578 to the latest identity as of 7.999
GET /node/receipt?asof=5.578 | x-ms-ccf-txid: 5.578 => receipt + no chain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants