Ensure raft traces are always uploaded as workflow artifacts. (#6451)

Signed-off-by: Markus Alexander Kuppe <[email protected]>
microsoft · Aug 28, 2024 · 7540df4 · 7540df4
1 parent c0178a7
commit 7540df4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/.github/workflows/tlaplus.yml b/.github/workflows/tlaplus.yml
@@ -250,7 +250,7 @@ jobs:
 
       - name: Upload artifacts.
         uses: actions/upload-artifact@v4
-        if: ${{ failure() }}
+        if: always()
         with:
           name: tlc
           path: |

diff --git a/tests/raft_scenarios_runner.py b/tests/raft_scenarios_runner.py
@@ -169,12 +169,14 @@ def expand_files(files):
         with block(ostream, "diagram", 3, "mermaid", ["sequenceDiagram"]):
             ostream.write(mermaid)
 
-        with open(
-            os.path.join(output_dir, f"{os.path.basename(scenario)}.ndjson"),
-            "w",
-            encoding="utf-8",
-        ) as f:
-            f.write(log)
+        ## Do not create an empty ndjson file if log is emtpy.
+        if log:
+            with open(
+                os.path.join(output_dir, f"{os.path.basename(scenario)}.ndjson"),
+                "w",
+                encoding="utf-8",
+            ) as f:
+                f.write(log)
 
     write_error_report(err_list)