fix: allow any standard HTML attributes as props in the NanoClamp type #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
obecker
commented
Mar 24, 2024
obecker
commented
- Fixes TypeScript problem: Property className does not belong to the Props type definition #26
breadadams
reviewed
Mar 24, 2024
There was a problem hiding this comment.
Thanks for the contribution @obecker, couple of minor suggestions
…e definition + Fixes microlinkhq#26
|
@obecker Thanks for this! This library is mainly in maintenance mode, but even though we are not actively developing this library, any PR that improves the library (like this one) will be merged and released, so please feel free to open as many PRs as you like! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.